Attention is currently required from: keith, pespin.
View Change
1 comment:
File src/libmsc/db.c:
Patch Set #4, Line 302: id = $id LIMIT 1
Why are you adding `LIMIT 1`? Can there really be more than one entry with `id = $id`?
To view, visit change 28340. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603
Gerrit-Change-Number: 28340
Gerrit-PatchSet: 4
Gerrit-Owner: keith <keith@rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: keith <keith@rhizomatica.org>
Gerrit-Comment-Date: Sat, 11 Oct 2025 07:38:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No