Attention is currently required from: pespin.

View Change

3 comments:

• File src/common/rtp_abstract.c:

  • Patch Set #3, Line 14: #define HAVE_ORTP

    s/tab/space/ ?

    I will change it in the next iteration if Osmocom style preference is to use space here.

  • Patch Set #3, Line 54: #ifdef HAVE_ORTP

    I think splitting the whole implementation into 2 different main blocks (reimplementing functions on […]

    How do you propose doing so? Each function needs to check if the `rtp_abst_socket` it operates on was created in ortp or twrtp mode.

  • Patch Set #3, Line 169: osmo_twrtp_twjit_rx_ctrl(rs->twrtp, true);

    is it needed to call this every time we poll?

    Not needed, but no harm either. We do need to make sure that it is only called when we are truly ready to commit to polling, and I couldn't find a better way.

To view, visit change 42165. To unsubscribe, or for help writing mail filters, visit settings.