Attention is currently required from: osmith.

View Change

2 comments:

• File include/osmocom/gprs/sm/sm_private.h:

  • Patch Set #6, Line 159: struct osmo_gprs_sm_prim *gprs_sm_prim_alloc_smreg_pdp_deact_ind(void);

    should everything about deact_ind go into a separate patch? or how does it relate to GMMSM-MODIFY. […]

    It's just part of the handling of GMMSM-MODIFY.ind, see the rest of the patch.
    In summary, GMMSM-MODIFY.ind is trigged by rx GMM RAU Accept, which contains a PDP Context Status IE, which may trigger in the SM layer the deactivation of PDP context, which are then to be announced to the upper layers (through the SMREG interface).

• File src/sm/sm_prim.c:

  • Patch Set #6, Line 603: */

    did you leave this and the TODO below intentionally?

    Yes, this is not really needed for now since it's for acknowledged mode, which afaik we are not even implementing on the network side.

    That's really another feature which may be implemented in the future. I'm just leaving the TODO there since I was looking at related specs.

To view, visit change 33811. To unsubscribe, or for help writing mail filters, visit settings.