fixeria submitted this change.
BTS_Tests: exec TC_sacch_chan_act_ho_{sync,async} on g_AllChanTypes[]
Currently we execute both test cases on *all* available dedicated
channels from g_AllChannels[]. Given that SACCH is slow, and in
some cases we intentionally wait for a timeout of 3.0 seconds to
expire, the overall execution time is quite long. We have a risk
of the test execution being aborted due to the guard timeout.
I agree that using g_AllChannels[] makes sense for TC_ho_rach, which
tests handover RACH detection. There we want to be sure that detection
works on all slots of all DCCH types (especially when running a setup
with real MS/BTS hardware).
But for both TC_sacch_chan_act_ho_{sync,async} it's enough to run
on different channel types (see g_AllChanTypes[]), because what
we actually want to test is the Downlink SACCH operation.
Change-Id: Ic1937edd72ff842cb619e153d0f6a624ceb95281
Related: SYS#5838, OS#4008, OS#4009
---
M bts/BTS_Tests.ttcn
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index ab7c979..b95648a 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1406,9 +1406,9 @@
var ConnHdlrPars pars;
f_init();
- for (var integer i := 0; i < sizeof(g_AllChannels); i := i+1) {
- pars := valueof(t_Pars(g_AllChannels[i], ts_RSL_ChanMode_SIGN));
- log(testcasename(), ": Starting for ", g_AllChannels[i]);
+ for (var integer i := 0; i < sizeof(g_AllChanTypes); i := i+1) {
+ pars := valueof(t_Pars(g_AllChanTypes[i], ts_RSL_ChanMode_SIGN));
+ log(testcasename(), ": Starting for ", g_AllChanTypes[i]);
vc_conn := f_start_handler(refers(f_TC_sacch_chan_act_ho_async), pars);
vc_conn.done;
}
@@ -1532,9 +1532,9 @@
var ConnHdlrPars pars;
f_init();
- for (var integer i := 0; i < sizeof(g_AllChannels); i := i+1) {
- pars := valueof(t_Pars(g_AllChannels[i], ts_RSL_ChanMode_SIGN));
- log(testcasename(), ": Starting for ", g_AllChannels[i]);
+ for (var integer i := 0; i < sizeof(g_AllChanTypes); i := i+1) {
+ pars := valueof(t_Pars(g_AllChanTypes[i], ts_RSL_ChanMode_SIGN));
+ log(testcasename(), ": Starting for ", g_AllChanTypes[i]);
vc_conn := f_start_handler(refers(f_TC_sacch_chan_act_ho_sync), pars);
vc_conn.done;
}
To view, visit change 27490. To unsubscribe, or for help writing mail filters, visit settings.