Attention is currently required from: daniel, laforge, pespin.

View Change

1 comment:

• File src/core/gsmtap_util.c:

  • Patch Set #5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL);

    I have (for now) fixed the memleak keeping Osmo IO, since it was a quick fix and I'm not entirely I understand what you mean by

    simply never read from that fd and just keep it open there so no ICMP errors are sent

    ?

    
    I would think it means returning after the `fd = gsmtap_source_add_sink_fd(gsmtap_inst_fd2(gti));` line in `gsmtap_source_add_sink()`, but then I wouldn't understand why the call to `read()` was added to the Osmo FD callback in the original code.

    I can of course also just go back to what the code did before (regarding sink functionality), but I thought I'd ask, since you mentioned these two options.

To view, visit change 34743. To unsubscribe, or for help writing mail filters, visit settings.