Attention is currently required from: jolly, laforge, dexter.

View Change

4 comments:

• File src/libosmo-mgcp/mgcp_conn.c:

  • Patch Set #4, Line 176: /* Do not allow more then the maximum number of connections */

    you could take the cance to fix the "then" typo :D

  • Patch Set #4, Line 177: if (endp->type->max_conns && llist_count(&endp->conns) >= endp->type->max_conns)

    max_conns > 0 may be clearer here.

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #4, Line 1329: if (conn->mode != MGCP_CONN_RECV_ONLY &&

    sounds like you want to use a switch() here? It's difficult to gasp the different cases otherwise.

  • Patch Set #4, Line 1342: if (conn_dst->mode == MGCP_CONN_SEND_ONLY ||

    Also lots of mode checking here. I bet this all can be improved a lot by re-thinking it and using switch statements, etc.

To view, visit change 33548. To unsubscribe, or for help writing mail filters, visit settings.