Attention is currently required from: daniel, fixeria, laforge, pespin.
Patch set 2:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #2:
The patch looks good to me. Since these are just internal changes in libosmo-sigtran (from what I can tell no Osmocom program/library is using the modified functions directly outside of libosmo-sigtran, even the non-static ones) and Pau said that all tests pass with this, it should be fine to merge this IMHO if Harald is fine with the architectural change.
To view, visit change 39396. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I49e718e624da08510a9c3d28bdb360c59f9a65d3
Gerrit-Change-Number: 39396
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Fri, 24 Jan 2025 11:00:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes