Attention is currently required from: arehbein, fixeria, msuraev.
View Change
1 comment:
File src/common/vty.c:
Patch Set #9, Line 473: vty_out(vty, " pcu-socket-wqueue-length %d%s", bts->pcu.sock_wqueue_len_max, VTY_NEWLINE);
Odd, that should give a warning during compilation: sock_wqueue_len_max is declared as unsigned int […]
I agree with max. It is an unsigned int, so %d should cause a compiler warning. Not sure why it doesn't happen, but in any case printing unsinged as signed is not correct.
To view, visit change 31534. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id6ba6e4eadce9ce82ef2407f4e28346e7fe4abfa
Gerrit-Change-Number: 31534
Gerrit-PatchSet: 15
Gerrit-Owner: arehbein <arehbein@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: msuraev <msuraev@sysmocom.de>
Gerrit-Attention: arehbein <arehbein@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: msuraev <msuraev@sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Jun 2023 14:47:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev@sysmocom.de>
Gerrit-MessageType: comment