laforge submitted this change.

View Change

Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified
build: pass FFTWF_CFLAGS to arch/common

configure looks up fftw3f with pkg-config for the multi-ARFCN build and
puts FFTWF_LIBS on the link line of the transceiver, but
Transceiver52M/arch/common/Makefile.am, where fft.c lives, never uses
FFTWF_CFLAGS. The compile of fft.c therefore only works where fftw3.h
is in a default include directory.

With fftw from Homebrew on macOS ARM64 the header is in
/opt/homebrew/include, which clang does not search by default:

arch/common/fft.c:26:10: fatal error: 'fftw3.h' file not found

Add FFTWF_CFLAGS to AM_CFLAGS in that directory. No change where the
header was already found.

Change-Id: I3243ce00bd42a22ff0fbbdd5ff3d00c7441662d0
Signed-off-by: Andrei Gosman <andrei.gosman@gmail.com>
---
M Transceiver52M/arch/common/Makefile.am
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Transceiver52M/arch/common/Makefile.am b/Transceiver52M/arch/common/Makefile.am
index a27174d..c23d3b4 100644
--- a/Transceiver52M/arch/common/Makefile.am
+++ b/Transceiver52M/arch/common/Makefile.am
@@ -1,4 +1,4 @@
-AM_CFLAGS = -Wall -std=gnu99
+AM_CFLAGS = -Wall -std=gnu99 $(FFTWF_CFLAGS)

noinst_LTLIBRARIES = libarch_common.la


To view, visit change 43581. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I3243ce00bd42a22ff0fbbdd5ff3d00c7441662d0
Gerrit-Change-Number: 43581
Gerrit-PatchSet: 1
Gerrit-Owner: Andrei G <andrei.gosman@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>