Attention is currently required from: Timur Davydov.

View Change

1 comment:

• File Transceiver52M/Transceiver.cpp:

  • Patch Set #3, Line 1026: return -EINVAL;

    The logic is preserved here. […]

    My point is that I don't see why do you decided to move the "return EINVAL here instead of 0 and decide to convert EINVAl to o 0 in other function" logic.
    I see no good reason to do that in this patch.

    
    If you consider that this path should return an error instead of 0 (which may be correct) then please submit a different patch changing this.
    It seems the diferentiation for this path returning non-error was made in 76ff96e21079db2cd7123ff9ca33fa7d2fb0cb01 (by me) but there's no real description on why was that, and I think we should indeed fail if timeslot reading fails.
    So please, if you want to change the logic, submit a patch before or after this one.

To view, visit change 42410. To unsubscribe, or for help writing mail filters, visit settings.