laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve laforge: Looks good to me, approved
rspro_util: asn1 decode: fix memleak when decoding fails

Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27
---
M src/rspro_util.c
1 file changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/rspro_util.c b/src/rspro_util.c
index 23bb839..b4b473e 100644
--- a/src/rspro_util.c
+++ b/src/rspro_util.c
@@ -86,6 +86,8 @@
LOGP(DRSPRO, LOGL_DEBUG, "decoding %s\n", msgb_hexdump(msg));
rval = ber_decode(NULL, &asn_DEF_RsproPDU, (void **) &pdu, msgb_l2(msg), msgb_l2len(msg));
if (rval.code != RC_OK) {
+ if (pdu)
+ ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu);
LOGP(DRSPRO, LOGL_ERROR, "Failed to decode: %d. Consumed %zu of %u bytes\n",
rval.code, rval.consumed, msgb_length(msg));
return NULL;

To view, visit change 42705. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27
Gerrit-Change-Number: 42705
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: laforge <laforge@osmocom.org>