Attention is currently required from: pespin.

View Change

3 comments:

• File src/sgsn/sgsn_libgtp.c:

  • Patch Set #1, Line 707: if (gtpie_gettlv(ie, GTPIE_RIM_RA_DISCR, 0, &rim_ra_encoded_len, rim_ra_encoded,

    can you move thisgtpie_gettlv() call to be "rc = ... […]

    Done

  • Patch Set #1, Line 714: rim_ra_encoded[0] = BSSGP_RIM_ROUTING_INFO_UTRAN;

    why are you using an array in here? we have no packed struct explaining what is this buffer?

    The problem here is that we deal with two different types, RIM ROUTING ADDRESS and RIM ROUTING INFORMATION. RIM ROUTING INFORMATION is basically RIM ROUTING ADDRESS DISCRIMINATOR (1 byte) + RIM ROUTING ADDRESS - but I see, this is probably not very elegant. We should have a decoder that handles this.

  • Patch Set #1, Line 715: }

    rim_ra_encoded++;

    Done

To view, visit change 34122. To unsubscribe, or for help writing mail filters, visit settings.