Attention is currently required from: pespin, dexter.

Patch set 5:Code-Review -1

View Change

4 comments:

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #5, Line 445: confirmation

    Same as in the related osmo-bts patch: "Sending confirmation" may be confusing, let's make this cleaner by saying "Sending DATA.cnf" or "Sending data confirmation".

  • Patch Set #5, Line 533: struct gsm_pcu_if_agch *agch;

    const

  • Patch Set #5, Line 551: rc = -EIO;

    So if `agch->confirm == true`, but `rsl_imm_assign_cmd()` fails, we still send the confirmation. This looks wrong to me. Am I missing something?

  • Patch Set #5, Line 555: gsm48_imm_ass = (struct gsm48_imm_ass *)agch->data;

    You're setting this pointer, but not using it within this `case`.

To view, visit change 34060. To unsubscribe, or for help writing mail filters, visit settings.