Attention is currently required from: Hoernchen, lynxis lazus.
View Change
2 comments:
File usb_start.c:
Patch Set #2, Line 171: /* FIXME: check if dfu_download_offset / length are valid */
the fixme or the lines above? […]
The FIXME.
Patch Set #2, Line 178: CRITICAL_SECTION_ENTER();
yes, for dfu_download_offset and to ensure `dfu_flash_done = true` isn't set without dfu_flash_statu […]
Done
To view, visit change 42174. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef
Gerrit-Change-Number: 42174
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis@fe80.eu>
Gerrit-Comment-Date: Mon, 23 Feb 2026 10:18:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>