Attention is currently required from: falconia.

View Change

6 comments:

• File include/osmo-bts/rtp_abstract.h:

  • Patch Set #3, Line 50: struct sockaddr_in local_addr;

    struct osmo_sockaddr, so we support IPv6 too.

• File src/common/rtp_abstract.c:

  • Patch Set #3, Line 14: #define HAVE_ORTP

    s/tab/space/ ?

  • Patch Set #3, Line 54: #ifdef HAVE_ORTP

    I think splitting the whole implementation into 2 different main blocks (reimplementing functions on each one) will be a lot cleaner and easy to understand and maintain, as well as easier to drop ortp in the future.

  • Patch Set #3, Line 97: rc = inet_aton(ipstr, &rs->local_addr.sin_addr);

    osmo_sockaddr_from_str_and_uint(), so we support ipv6 too.

  • Patch Set #3, Line 109: const struct in_addr *ip, uint16_t port)

    Ah I see, we didn't support IPv6 here yet because ortp doesn't support it?
    Then it's fine to skip IPv6 support for now, but still it may be good to pave the way by using osmo_sockaddr functions to it's easier to enable in the future.

  • Patch Set #3, Line 169: osmo_twrtp_twjit_rx_ctrl(rs->twrtp, true);

    is it needed to call this every time we poll?

To view, visit change 42165. To unsubscribe, or for help writing mail filters, visit settings.