Attention is currently required from: laforge.
Patch set 1:Code-Review +2
1 comment:
Patchset:
This shows one more reason to have unit tests (see my other related comment to another patch in this […]
I hope you realize that when someone uses their non-funded spare time to make improvements to retronetworking functionality, they cannot be held to the same standard (w.r.t. unit test requirements) as paid employees working on functionality that has commercial backing. That being said, if and when I receive that promised InSite BTS from @osmocom.account@tbspace.de, once I get it running and capture some real-life TRAU-UL traffic (plus real-life TRAU-DL output from the TCSM2 TRAU I already have), I will look into putting together some unit tests based on those real-life traffic examples.
Meanwhile, on the present patch, seeing 3 CR+1's including yours, I will go ahead and CR+2 it, then merge the series in which the other two patches already got CR+2.
To view, visit change 37285. To unsubscribe, or for help writing mail filters, visit settings.