laforge submitted this change.

View Change

Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified
fsm_vty: use unsigned int when left-shifting 31 bits!

fsm_vty.c:64:8: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'

Change-Id: I637bce52fae947922cbb8642a0313d174c827422
---
M src/vty/fsm_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vty/fsm_vty.c b/src/vty/fsm_vty.c
index 025d0d8..777d38c 100644
--- a/src/vty/fsm_vty.c
+++ b/src/vty/fsm_vty.c
@@ -61,7 +61,7 @@
if (fsm->event_names) {
for (evt_name = fsm->event_names; evt_name->str != NULL; evt_name++) {
vty_out(vty, "%s Event %02u (0x%08x): '%s'%s", prefix, evt_name->value,
- (1 << evt_name->value), evt_name->str, VTY_NEWLINE);
+ (1U << evt_name->value), evt_name->str, VTY_NEWLINE);
}
} else
vty_out(vty, "%s No event names are defined for this FSM! Please fix!%s", prefix, VTY_NEWLINE);

To view, visit change 28128. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I637bce52fae947922cbb8642a0313d174c827422
Gerrit-Change-Number: 28128
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged