laforge submitted this change.

View Change

Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified
crypto_utils: extend TODO for better understanding

Related: SYS#8100
Change-Id: I411a3b4216b3c0d707d571b7a0c178e001931139
---
M src/crypto_utils.erl
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/crypto_utils.erl b/src/crypto_utils.erl
index cb50415..4a43407 100644
--- a/src/crypto_utils.erl
+++ b/src/crypto_utils.erl
@@ -31,7 +31,7 @@

%Encode the association token as BER TLV IE
enc_association_token(AssociationToken) ->
- %TODO: replace this with a proper ASN.1 encoding function.
+ %TODO: Define an ASN.1 type for the AssociationToken and use it to get rid of this half-baked encoder function.
AssociationTokenBinary = utils:integer_to_bytes(AssociationToken),
AssociationTokenLength = utils:integer_to_bytes(byte_size(AssociationTokenBinary)),
utils:join_binary_list([<<132>>, AssociationTokenLength, AssociationTokenBinary]).

To view, visit change 43502. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I411a3b4216b3c0d707d571b7a0c178e001931139
Gerrit-Change-Number: 43502
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>