Attention is currently required from: laforge, pespin.
View Change
1 comment:
Patchset:
Patch Set #1:
To me its clear given the combination matrix above that it makes no sense to create a type for each […]
Ok, thank you @pespin@sysmocom.de and @laforge@osmocom.org for the feedback! I will rework the VTY commands, marking as WIP for now. BTW, I think we also want to rename the `sctp-role (client|server)` command to something more neutral.
To view, visit change 35796. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d
Gerrit-Change-Number: 35796
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: jolly <andreas@eversberg.eu>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Feb 2024 13:06:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment