Attention is currently required from: fixeria.

View Change

3 comments:

• File src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h:

  • Patch Set #2, Line 166: #define L1SCHED_PROBE_F_ACTIVE (1 << 0)

    That looks odd. Why not simply put 1?

• File src/host/trxcon/include/osmocom/bb/trxcon/phyif.h:

  • Patch Set #2, Line 85: #define TRXCON_PHYIF_RTR_F_ACTIVE (1 << 0)

    Same here.

• File src/host/trxcon/src/sched_trx.c:

  • Patch Set #2, Line 829: return -ENODEV;

    Would be better to use different error code to distinguish between different errors.

To view, visit change 30262. To unsubscribe, or for help writing mail filters, visit settings.