Attention is currently required from: falconia.
Patch set 1:Code-Review +1
2 comments:
File src/codec/gsm660.c:
Patch Set #1, Line 271: static con
not a request to change: just a question. Why use 'static' here? does it change anything? Wouldn't a 'const uint8_t' array always be put in rodata anyway, without any 'static'?
/* bit numbers relative to "pure" EFR frame beginning,
* not counting the signature bits. */
45, 46, 48, 49, 50, 51, 52, 53, 54, 55,
56, 57, 58, 59, 60, 61, 62, 63, 64, 65,
66, 67, 68, 94, 95, 96, 98, 99, 100, 101,
102, 103, 104, 105, 106, 107, 108, 109, 110, 111,
112, 113, 114, 115, 116, 117, 118, 148, 149, 150,
151, 152, 153, 154, 155, 156, 157, 158, 159, 160,
161, 162, 163, 164, 165, 166, 167, 168, 169, 170,
171, 196, 197, 198, 199, 200, 201, 202, 203, 204,
205, 206, 207, 208, 209, 212, 213, 214, 215, 216,
217, 218, 219, 220, 221 };
one tab indent too much, at least it looks that way in gerrit
To view, visit change 32034. To unsubscribe, or for help writing mail filters, visit settings.