Patch Set 1: Code-Review+1

I'm wondering why call_leg_local_bridge() is even called before all sides are ready.
I think placing a safeguard here to avoid a crash is a good thing (fix DoS).

But if the RAB Assignment didn't complete, it should not even be reaching this stage, right?

Agree, I also find this a bit weird that it reaches this point. I guess on the 3g side (MO side) the call proceeds due to CM Service Request, and is not currently waiting for RAB Assignment-Response?

View Change

To view, visit change 26917. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I67d2d5b2dd3b367c34f929d63c056306ec001431
Gerrit-Change-Number: 26917
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Fri, 14 Jan 2022 18:47:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment