Attention is currently required from: arehbein, daniel, laforge, pespin.

View Change

3 comments:

• Commit Message:

  • Patch Set #4, Line 11: from distinguishing between write_cb() and sendto_cb() etc.

    AFAIU, iofd->mode should distinguish which union members are in use, so it should be possible to handle things properly .. where exactly is the bug this is fixing? is the mode switched without NULLing the cb pointers or something in that way?

• File src/core/osmo_io.c:

  • Patch Set #3, Line 546: if (iofd->io_ops.read_cb)

    The fact that this happened to work is even more reason to remove the union.

    i fail to see the problem though, can you explain?

• File src/core/osmo_io.c:

  • Patch Set #4, Line 391: || (iofd->mode == OSMO_IO_FD_MODE_RECVFROM_SENDTO && iofd->io_ops.recvfrom_cb));

    this code should also work with the union present?

To view, visit change 35079. To unsubscribe, or for help writing mail filters, visit settings.