Attention is currently required from: osmith.

Patch set 9:Code-Review -1

View Change

3 comments:

• File src/osmo-bts-sysmo/l1_if.c:

  • Patch Set #7, Line 1271: oml_mo_rf_lock_chg(&trx->mo, fl1h->last_rf_mute, 0);

    I've verified that it sends a Change Administrative State Ack/Nack. […]

    FYI you can also see what's done in osmo-bts-trx, something similar:

    """
    static void st_open_poweroff_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state)
    {
    	struct trx_l1h *l1h = (struct trx_l1h *)fi->priv;
    	struct phy_instance *pinst = l1h->phy_inst;

    	trx_provision_reset(l1h);

    	if (pinst->trx == NULL) {
    		trx_if_cmd_rfmute(l1h, true);
    		return;
    	}

    	/* Apply initial RFMUTE state */
    	trx_if_cmd_rfmute(l1h, pinst->trx->mo.nm_state.administrative != NM_STATE_UNLOCKED);

    	osmo_fsm_inst_dispatch(pinst->trx->mo.fi, NM_EV_SW_ACT, NULL);
    	osmo_fsm_inst_dispatch(pinst->trx->bb_transc.mo.fi, NM_EV_SW_ACT, NULL);
    }
    """

• File src/osmo-bts-sysmo/l1_if.c:

  • Patch Set #9, Line 1271: if (trx->mo.opstart_success)

    Better use this below, the opstart_success field is a flag used internally by the FSM. Idealyl we should send an event to the FSM and the FSM should take care of sending that message, but that's not implemented yet.

    if (trx->mo.fi->state != NM_RCARRIER_ST_OP_DISABLED_NOTINSTALLED)

  • Patch Set #9, Line 1279: if (trx->mo.opstart_success)

    if (trx->mo.fi->state != NM_RCARRIER_ST_OP_DISABLED_NOTINSTALLED)

To view, visit change 33457. To unsubscribe, or for help writing mail filters, visit settings.