Attention is currently required from: neels, pespin.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/osmo-bsc/bsc_sccp.c:

  • Patch Set #1, Line 55: next_id = (next_id + 1) & 0x00FFFFFF;

    Looks like you can simply do: `(next_id + 1) % 0x00FFFFFF`?
    I see you're just copying code, maybe an idea for a separate patch.
    But wait, is it possible at all given that `i` is in range `0..0x00FFFFFE`?

To view, visit change 31811. To unsubscribe, or for help writing mail filters, visit settings.