Attention is currently required from: pespin.

View Change

3 comments:

• File include/osmocom/mgcp_client/mgcp_client.h:

  • Patch Set #2, Line 121: struct mgcp_msg {

    If this struct is being allocated outside of the library, now it's for sure the moment to add an all […]

    I have checked this one. It is not used from outside. I think there would also be no point in doing so since this struct models the MGCP messages that are exchanged and the purpose of the mgcp-client is to keep exactly that away from the user.

• File include/osmocom/mgcp_client/mgcp_client_fsm.h:

  • Patch Set #2, Line 70: struct mgcp_codec_param2 codecs_param[MGCP_MAX_CODECS];

    as soon as you add a field to "struct mgcp_codec_param2", the size of the struct will and change any […]

    Yes, that is a real problem ;-/ I will add an alloc function in a different patch.

• File src/libosmo-mgcp-client/mgcp_client.c:

  • Patch Set #2, Line 1376: LOGPMGW(mgcp, LOGL_DEBUG, "using depreacted struct member mgcp_msg->param, please use mgcp_msg->codecs_param!\n");

    only debug?

    Done

To view, visit change 34351. To unsubscribe, or for help writing mail filters, visit settings.