Attention is currently required from: jolly.

Patch set 2:Code-Review -1

View Change

2 comments:

• File include/osmocom/abis/e1_input.h:

  • Patch Set #2, Line 197: int (*set_cas)(struct e1inp_ts *ts, uint8_t bits, bool query_rx);

    You are breaking ABI here, see:

        ../osmo-bsc/src/ipaccess/ipaccess-config-e1-driver.c
        453:static struct e1inp_driver ipaccess_config_driver = {
        

    
    So at least set the field at the end of the struct, and remember to add a TODO-RELEASE entry specifying ABI break of libosmoabis.

  • Patch Set #2, Line 414: uint8_t cas;

    ABI break, you must at least put this at the end of the struct and mention it in TODO-RELEASE, see accesses in:

    ../openbsc/openbsc/src/libbsc/bsc_init.c
    342: struct input_signal_data *isd = signal_data;

    ../openbsc/openbsc/src/libbsc/bts_ericsson_rbs2000.c
    111: struct input_signal_data *isd = signal_data;

    ../openbsc/openbsc/src/libbsc/bts_nokia_site.c
    144: struct input_signal_data *isd = signal_data;

    ../openbsc/openbsc/src/libbsc/bts_siemens_bs11.c
    566: struct input_signal_data *isd = signal_data;

    ../osmo-bsc/src/ipaccess/ipaccess-config.c
    373: struct input_signal_data *isd = signal_data;

    ../osmo-bsc/src/ipaccess/ipaccess-config-e1-driver.c
    80: struct input_signal_data isd;

    ../osmo-bsc/src/osmo-bsc/bts_ericsson_rbs2000.c
    113: struct input_signal_data *isd = signal_data;

    ../osmo-bsc/src/osmo-bsc/bts_nokia_site.c
    155: struct input_signal_data *isd = signal_data;

    ../osmo-bsc/src/osmo-bsc/bts_siemens_bs11.c
    518: struct input_signal_data *isd = signal_data;

    ../osmo-bsc/src/osmo-bsc/osmo_bsc_main.c
    455: struct input_signal_data *isd = signal_data;

    ../osmo-bts/src/common/abis.c

    490: struct input_signal_data *isd = signal_data;

    
    Specially important this user of the struct, I at least improved it a bit by zero-initializing the struct here: https://gerrit.osmocom.org/c/osmo-bsc/+/41773

To view, visit change 41140. To unsubscribe, or for help writing mail filters, visit settings.