neels submitted this change.

View Change

Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified
ps_rab_fsm: check use cb success

Related: CID#275413 CID#275410 CID#275409
Related: SYS#5895
Change-Id: Idcb3d6796326b059280b0e552eb36067ba15b3ac
---
M src/osmo-hnbgw/ps_rab_fsm.c
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/osmo-hnbgw/ps_rab_fsm.c b/src/osmo-hnbgw/ps_rab_fsm.c
index 8578561..dcc18ca 100644
--- a/src/osmo-hnbgw/ps_rab_fsm.c
+++ b/src/osmo-hnbgw/ps_rab_fsm.c
@@ -106,7 +106,7 @@
};
fi->priv = rab;

- osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, 1);
+ OSMO_ASSERT(osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, 1) == 0);

llist_add_tail(&rab->entry, &map->ps_rabs);
return rab;
@@ -139,7 +139,7 @@
m->ctx.session_fi = rab->fi;
m->ctx.session_use_count = &rab->use_count;
m->ctx.session_use_token = "PFCP_MSG";
- osmo_use_count_get_put(m->ctx.session_use_count, m->ctx.session_use_token, 1);
+ OSMO_ASSERT(osmo_use_count_get_put(m->ctx.session_use_count, m->ctx.session_use_token, 1) == 0);
}

static struct osmo_pfcp_msg *ps_rab_new_pfcp_msg_req(struct ps_rab *rab, enum osmo_pfcp_message_type msg_type)
@@ -663,7 +663,7 @@
static void ps_rab_fsm_wait_use_count_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state)
{
struct ps_rab *rab = fi->priv;
- osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, -1);
+ OSMO_ASSERT(osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, -1) == 0);
}

static void ps_rab_fsm_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data)

To view, visit change 29072. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Idcb3d6796326b059280b0e552eb36067ba15b3ac
Gerrit-Change-Number: 29072
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-MessageType: merged