Attention is currently required from: pespin.

View Change

2 comments:

• File src/gprs_ms.c:

  • Patch Set #2, Line 355: OSMO_ASSERT(ms);

    it's not really the same. […]

    Not that I wanted to block you here... But looking at the function signature, I would never assume that any of the pointer arguments are optional and can legally/intentionally be NULL here. I wish there was some kind of notation in C to express that some pointer can/shall never be NULL (or vice versa).

  • Patch Set #2, Line 419: OSMO_ASSERT(tbf_ms(tbf) == ms);

    I can add an OSMO_ASSERT(tbf) there if you want, but it's clear here that it is expected to be not N […]

    No no no, no more asserts please.

To view, visit change 32358. To unsubscribe, or for help writing mail filters, visit settings.