Attention is currently required from: fixeria, laforge, lynxis lazus.
1 comment:
Patchset:
at a high level it looks a bit like this could/should be possible ot handle with @decmatch and a lot […]
while I agree decmatch is useful in several places, I believe in this specific case it is fine leaving as is. why?
Because the TLA octet decoding actually needs some heuristic logic to try to figure out whether it's using a raw IP address or an X.213 formatted IP address. One needs to check the size of the octet buffer in order to figure out which type of address it is, and then validate it checking values in the octet string, etc.
So ideally in there we'd have a function checking that kind of heuristics, like ranap_transp_layer_addr_decode2() does. But since here I know osmo-sgsn is apparently always sending an X.213 address I didn't care implementing the function for now.
To view, visit change 38433. To unsubscribe, or for help writing mail filters, visit settings.