Attention is currently required from: dexter.

View Change

6 comments:

• File src/nacc_fsm.c:

  • Patch Set #2, Line 273: /* Classify the RAT type of the cell that is proposed in the PacketCellChangeNotification. In case the RAT is GERAN,

    Can you maybe convert these defines to an enum and provide spec reference on where to find this exactly?

  • Patch Set #2, Line 278: static int fill_neigh_key_from_bts_pkt_cell_chg_not(struct nacc_fsm_ctx *ctx,

    I actually think you don't need to return 0/1/2 here, see below.

  • Patch Set #2, Line 344: return NACC_EUTRAN_CELL;

    maybe set ctx->neigh_key_valid = false explicitly for readers to understand better (and to make sure the field is initialized/overwritten).

  • Patch Set #2, Line 398: } else if (rc == NACC_UTRAN_CELL || rc == NACC_EUTRAN_CELL) {

    I think in here what you may actually want to do is:

    """
    if (!ctx->neigh_key_valid) {
    		/* When the proposed call is an UTRAN or EUTRAN cell, we won't provide any system information
    		 * to the UE. Instead we will send the PacketCellChangeContinue message immediately. This also
    		 * applies in the case of re-transmissions. See also: 3GPP TS 48.018, section 8c.6.1. */
    		LOGPFSML(ctx->fi, LOGL_NOTICE,
    			 "Target cell is an UTRAN or EUTRAN cell => no system information provided.\n");
    		nacc_fsm_state_chg(ctx->fi, NACC_ST_TX_CELL_CHG_CONTINUE);
    		return;
    }
    """

    So you don't really need to check whether it's GERAN/UTRAN/EUTRAN, but whether we actually got any neigh to ask information for... if no info to get, then continue straight to tx PKT CELL CHG CONTINUE.

  • Patch Set #2, Line 433: else if (rc == NACC_UTRAN_CELL || rc == NACC_EUTRAN_CELL) {

    see same as above.

• File src/neigh_cache.h:

  • Patch Set #2, Line 68: /* TODO: This function seems to be used only in neigh_cache.c, make it static? */

    this is definetly another patch. Fine with making it static.

To view, visit change 33538. To unsubscribe, or for help writing mail filters, visit settings.