Attention is currently required from: fixeria, osmith, pespin.

View Change

2 comments:

• File include/osmocom/pcu/pcuif_proto.h:

  • Patch Set #1, Line 16: #define PCU_IF_MSG_DATA_CNF 0x01 /* (deprecated) */

    What's the problem in having gaps? Those numbers are not used in the new version of the protocol, so […]

    I really se no problem with with having gaps. (I tend to say that we should leave it as it is now)

• File src/pcu_l1_if.cpp:

  • Patch Set #2, Line 744: if (info_ind->version == 0x0a) {

    I think you need to remove this too?

    Done

To view, visit change 34706. To unsubscribe, or for help writing mail filters, visit settings.