pespin submitted this change.

View Change

Fix handling of sctp SCTP_SHUTDOWN_EVENT notification

SCTP_SHUTDOWN_EVENT is a first class event, and not a subtype of
SCTP_ASSOC_CHANGE (such as SCTP_SHUTDOWN_COMP).

Related: SYS#6113
Change-Id: I7fa648142c07f63c55091d2a15b9d7312bcd4cec
---
M src/osmo-hnbgw/hnbgw.c
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c
index 6d75525..0c59c7d 100644
--- a/src/osmo-hnbgw/hnbgw.c
+++ b/src/osmo-hnbgw/hnbgw.c
@@ -262,15 +262,15 @@
 				LOGHNB(hnb, DMAIN, LOGL_NOTICE, "HNB SCTP conn RESTARTed, marking as HNBAP-unregistered\n");
 				hnb->hnb_registered = false;
 				break;
-			case SCTP_SHUTDOWN_EVENT:
-				LOGHNB(hnb, DMAIN, LOGL_NOTICE,
-				       "sctp_recvmsg(%s) = SCTP_SHUTDOWN_EVENT, closing conn\n",
-				       osmo_sock_get_name2(osmo_stream_srv_get_ofd(conn)->fd));
-				osmo_stream_srv_destroy(conn);
-				rc = -1;
-				break;
 			}
 			break;
+		case SCTP_SHUTDOWN_EVENT:
+			LOGHNB(hnb, DMAIN, LOGL_NOTICE,
+			       "sctp_recvmsg(%s) = SCTP_SHUTDOWN_EVENT, closing conn\n",
+			       osmo_sock_get_name2(osmo_stream_srv_get_ofd(conn)->fd));
+			osmo_stream_srv_destroy(conn);
+			rc = -1;
+			break;
 		}
 		goto out;
 	} else if (rc == -EAGAIN) {

To view, visit change 29546. To unsubscribe, or for help writing mail filters, visit settings.