Attention is currently required from: neels.
View Change
1 comment:
Patchset:
Patch Set #1:
Max, the difference is between detecting the address kind of a character string, vs detecting the ad […]
I don't see principal difference between guessing over data stored in string vs guessing over same data stored in struct.
The code in tests/socket/socket_sctp_test.c actively uses AF_UNSPEC with osmo_sock_init2_multiaddr() for example.
If we treat AF_UNSPEC as unrecoverable error we should be consistent and always do that.
To view, visit change 29122. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifadd614604cf9d0c2ed1a405493c1c3fcb37ae23
Gerrit-Change-Number: 29122
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 14:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>
Gerrit-MessageType: comment