Attention is currently required from: kirr.

kirr uploaded patch set #3 to this change.

View Change

The following approvals got outdated and were removed: Verified-1 by Jenkins Builder

[WIP] Revert "Revert "trx_toolkit/transceiver.py: implement the transmit burst queue""

This reverts commit d4ed09df57b3461470af501e9687ddd80eb78838,
reinstating tx queue into fake_trx.

It is ok to do so because, as explained in abc63d8d (trx_toolkit/clck_gen.py:
Fix clock generator not to accumulate timing error), the
reason for GSM clock jitter problem was timing error accumulation in
CLCKgen, not problems with py threading.Event.

Note: this restores original tx queue implementation basically as-is
with only resolve minor conflicts during the revert. The original tx
queue implementation wastes CPU cycles though because it linearly scans
the whole tx queue at every TDMA frame. If that CPU usage becomes a real
problem it should be straightforward to fix by reworking tx queue to use
priority queue instead of unordered array via heapq module from standard
library. See https://docs.python.org/3/library/heapq.html for details.

(WIP because I did not tested this patch fully as I could not yet
organize a working fake_trx setup due to not fully done homework yet)

Related: OS#4658, OS#6672
Change-Id: I41291708effdd2c767be680fff22ffbd9a56815e
---
M src/target/trx_toolkit/fake_trx.py
M src/target/trx_toolkit/transceiver.py
2 files changed, 72 insertions(+), 3 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/28/39328/3

To view, visit change 39328. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I41291708effdd2c767be680fff22ffbd9a56815e
Gerrit-Change-Number: 39328
Gerrit-PatchSet: 3
Gerrit-Owner: kirr <kirr@nexedi.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: osmith <osmith@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: kirr <kirr@nexedi.com>