Attention is currently required from: fixeria, lynxis lazus, pespin.

View Change

4 comments:

• File src/sgsn/gprs_sndcp_xid.c:

  • Patch Set #2, Line 293: /* Encode P0 (see also: 3GPP TS 44.065, 6.6.2.1, Table 7a) */

    For another commit: […]

    Its covered by the check above, but I agree, its a bit difficult to see. I will add another check in a follow up patch, so that we are still safe in case encode_pcomp_applicable_sapis writes more than 2 bytes - maybe when the spec gets upgraded and we do not notice, its a real risk...

  • Patch Set #2, Line 379: if (params->p3t < 0 || params->p3t > 65535 || params->p3t < 2 * params->p1t)

    better enclose (2*params->p1t) into parenthesis? also below in line 388.

    Done

  • Patch Set #2, Line 623: } else if (rc > 0) {

    no need for "} else" here (early return), remove it.

    But we still need the If then, because we do not want to do the tlv_put when the data length (rc) is 0.

  • Patch Set #2, Line 636: } else if (rc > 0) {

    no need for "} else" here (early return), remove it.

    Done

To view, visit change 43958. To unsubscribe, or for help writing mail filters, visit settings.