Attention is currently required from: fixeria, matanp.

View Change

1 comment:

• File src/osmo-bsc/bts_ctrl.c:

  • Patch Set #3, Line 531: cmd->reply = talloc_asprintf_append(cmd->reply, i == 0 ? "%u" : " %u", i);

    len('1 2 3 ... 1023') == 4009 […]

    I'd rather go for 1 allocation of 4096 bytes than potentially doing 1024 allocations, even if used with realloc. That would mean looking up for new space and potentially holding an allocation mutex lots of times.

To view, visit change 32565. To unsubscribe, or for help writing mail filters, visit settings.