Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File src/libosmo-mgcp/mgcp_codec.c:

  • Patch Set #1, Line 369: static bool codecs_same(struct mgcp_rtp_codec *codec_a, struct mgcp_rtp_codec *codec_b, bool match_pload_fmt)

    Yes, format conversion is transcoding in a "scientific" definition of the word. […]

    Ack

  • Patch Set #1, Line 431: /* In case we weren't able to find an exact match, we will try to find a match that is the same codec, but the

    agreeing with pespin

    Than it is probably better to refactor the existing code a bit. The function that finds the payload type on the opposite connection could also find a convertible codec that could be the exactly the same or something that OsmoMGW can convert. That would be more flexible as we get access to the resulting codec struct instead of only the payload type. I have put that part in a follow up patch.

To view, visit change 27392. To unsubscribe, or for help writing mail filters, visit settings.