Attention is currently required from: neels, fixeria, dexter.

View Change

5 comments:

• File include/osmocom/pcu/pcuif_proto.h:

  • Patch Set #19, Line 279: uint8_t pgroup;

    isn't pgroup going 0-999? that doesn't fit in a 8bit one (256)

• File src/bts.h:

  • Patch Set #19, Line 284: bool use_dt_confirm;

    I think it would be best to simply drop this bool, and explicitly check against received info_ind PCUIF version.

• File src/bts.cpp:

  • Patch Set #17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));

    Here is the related ticket: https://osmocom. […]

    I like the idea of supporting both 0x0a and 0x0b in osmo-pcu, that's great. I edited this comment because I was proposing exactly that and found out it's implemented in the next file in gerrit. Great!

• File src/pcu_l1_if.cpp:

  • Patch Set #19, Line 769: LOGP(DL1IF, LOGL_NOTICE, "selected IMMEDIATE assignment confirmation method (MAC block as reference) is deprecated. OS#5927\n");

    I think in here simply state that "PCUIF version 10 is deprecated" would be more interesting.

  • Patch Set #19, Line 771: } else {

    you cannot reach here according to if block in line 752.

To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.