Attention is currently required from: laforge, fixeria, pespin.

View Change

5 comments:

• File include/osmocom/hlr/gsup_server.h:

  • Patch Set #3, Line 71: osmo_gsup_create_insert_subscriber_data_msg

    Looks like it is, although only osmo-hlr seem to be using it. I did `. […]

    No. The gsup_server.h isn't installed and part if the noinst_HEADERS.

  • Patch Set #3, Line 71: osmo_gsup_create_insert_subscriber_data_msg

    Looks like it is, although only osmo-hlr seem to be using it. I did `. […]

    The header won't be installed and can't be used by other projects

• File src/hlr.c:

  • Patch Set #3, Line 133: sub_upd_ctx

    Let's better use `OTC_SELECT` and avoid `goto`s. […]

    Ack

• File src/lu_fsm.c:

  • Patch Set #3, Line 249: lu_isr_ctx

    I suggest simply using `OTC_SELECT` here.

    Done

  • Patch Set #3, Line 251: return

    memleak!

    Done

To view, visit change 32511. To unsubscribe, or for help writing mail filters, visit settings.