Attention is currently required from: fixeria, laforge.

Patch set 2:Code-Review +2

View Change

1 comment:

• File msc/BSC_ConnectionHandler.ttcn:

  • Patch Set #2, Line 1360: function f_expect_paging(template OCT4 tmsi := *)

    oh, i expected that it would need to adjust lots of callers...

    
    Not blocking; But this patch breaks one paradigm of this function: see below how we use g_pars.imsi.
    Now this is not using g_pars.tmsi as would be logical, but the caller is passing a TMSI explicitly.
    This is the reason why i all the time and still and always will think a boolean is semantically the right choice. To fix it, you'd also have to make the imsi an argument that is passed in and not taken from g_pars.

    But since someone spent time to submit the patch and it's good enough, I'll not make their life harder with my fringe opinion on the far corner of a ttcn3 test's helper function's type of an arg, and will accept the patch despite not matching my opinion.

    I'd like to see more of that, please, very large wink.

To view, visit change 36455. To unsubscribe, or for help writing mail filters, visit settings.