Attention is currently required from: fixeria, laforge.
View Change
1 comment:
Patchset:
Patch Set #6:
I didn't forget about this, the new patch set versions are probably created because I have re-based […]
I have now reviewed the code locations where we call send_apdu* methods. I have corrected TERMINAL PROFILE, ENVELOPE, and SUSPEND. As far as I can see FETCH and TERMINAL RESPONSE are not affected, since they work one layer below.
To view, visit change 37840. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10
Gerrit-Change-Number: 37840
Gerrit-PatchSet: 9
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Aug 2024 10:56:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: dexter <pmaier@sysmocom.de>