Attention is currently required from: pespin.

View Change

2 comments:

• File src/osmux_input.c:

  • Patch Set #2, Line 732: link->name = talloc_asprintf(link, "%p", h);

    To identify the different links by default without the user having to add a name (hence being able t […]

    That seems backwards to me. If old users want to identify links they could simply switch to using new API. And if they don't than it's pointless to carry workarounds to cater to that use-case.

• File tests/testsuite.at:

  • Patch Set #2, Line 14: # Following sed gets rid of pointer addresses to have reproducible output:

    Yeah, backward compatibility is though ;)

    This is not the case though - backward compatibility is when we keep old behavior for old API while adding new API. If we change behavior of old API to try to emulate the use of new API to the point that we have to rely on workarounds to keep unit tests from failing - it only adds unnecessary confusion.

To view, visit change 30210. To unsubscribe, or for help writing mail filters, visit settings.