Attention is currently required from: osmith, fixeria, pespin, msuraev.
9 comments:
Patchset:
it would be great to also see this tested in logging_vty_test.vty: i know it sounds annoying, but i've made so many mistakes already, merging broken vty commands i wrote ... now my opinion is that the only sane way to add vty commands is to add a *.vty test that verifies the doc strings are right and the config is written back ok. This patch affects all osmo programs so it's worth being tested.
so ... please add to tests/logging/logging_vty_test.vty lines like this:
# log?
# log ?
# log gsmtap ?
# log gsmtap foo ?
# log gsmtap foo 127.0.0.99
# show running-config
...
log gsmtap foo 127.0.0.99
...
literally like above, and then you can run
make vty-test U=-u
to automagically fill in what the vty returns
File src/core/logging_gsmtap.c:
(for doxygen: the summary line should end in a period '.')
It would be nice to point out the reason for version 2 to exist like
Same as log_target_create_gsmtap() with the possibility to provide a local IP and port to send gsmtap from.
or NULL for "localhost".
or zero for any local port.
or 0 to use GSMTAP_UDP_PORT.
(this one was also "missing" in the old doc, but might as well add it)
src can be passed as NULL, should we call talloc_strdup() on NULL?
File src/vty/logging_vty.c:
(i guess it should say "default is 127.0.0.1" but yes, not really part of this patch)
rather "any" .. at least some string literal instead of passing NULL to varargs, so that we have a definite deterministic string to test for in vty transcript testing if we ever want to
File utils/osmo-stat-dummy/osmo-stat-dummy.cfg:
Patch Set #4, Line 1: log gsmtap 127.0.0.69 127.6.9.1
what's the rationale for adding this here at all? don't we have some example cfg file for logging?
To view, visit change 31513. To unsubscribe, or for help writing mail filters, visit settings.