Attention is currently required from: fixeria, laforge, osmith.

View Change

1 comment:

• File tests/vty/osmo_stp_route_prio.vty:

  • Patch Set #2, Line 87: 3.2.1/14 0 as3 ? ? ?

    I agree, we should also use 5 as default. […]

    @laforge@gnumonks.org I'm fine with that, I can do that in a follow-up patch. Something related to discuss though: We are currently storing the value in uint32_t value in strcut osmo_ss7_route cfg.
    We could make that one a uint8_t, but that may break ABI compatibility.I'll check because anyway since we added secondary_pc we are already breaking ABI since last version.

    TBH I think we should break ABI once and move as many as possible of those structs into private headers. Same goes for most of the APIs too.
    This would make it far easier improving the library, since anyway when adding features will keep otherwise breaking ABI again and again.

To view, visit change 38375. To unsubscribe, or for help writing mail filters, visit settings.