Attention is currently required from: fixeria, pespin.

View Change

7 comments:

• File s1gw/S1GW_ConnHdlr.ttcn:

  • Patch Set #2, Line 1131: in ERabIdxList erabs_failed := {})

    No more "in" churn please.

    Done

  • Patch Set #2, Line 1706:

    	var ERabIdxList erabs_admitted;
    	for (var integer i := 0; i < lengthof(g_pars.erabs); i := i + 1) {
    		erabs_admitted[i] := i;
    	}
    

    See my comment about `f_ERabList_compose()` in previous patch.

    We cannot use f_ERabList_compose(), because we create an index list here.

  • Patch Set #2, Line 1720:

    f_ConnHdlr_tx_handover_ack(erabs_admitted, mme_ue_id, enb_ue_id, erabs_failed);
    	log("[eNB -> S1GW] -> MME: HANDOVER REQUEST ACKNOWLEDGE");
    

    We usually log first: […]

    Done

  • Patch Set #2, Line 1726:

    for (var integer i := 0; i < lengthof(erabs_admitted); i := i + 1) {
    			var ERabIdx idx := erabs_admitted[i];
    			erabs[i] := g_pars.erabs[idx];
    		}
    

    See my comment about `f_ERabList_compose()` in previous patch.

    Done

  • Patch Set #2, Line 1736:

    		for (var integer i := 0; i < lengthof(erabs_failed); i := i + 1) {
    			var ERabIdx idx := erabs_failed[i];
    			erabs[i] := g_pars.erabs[idx];
    		
    

    See my comment about `f_ERabList_compose()` in previous patch.

    Done

• File s1gw/S1GW_Tests.ttcn:

  • Patch Set #2, Line 955: f_ConnHdlr_handover_ack(

    no need for this extra line in params.

    Done

  • Patch Set #2, Line 962:

                    for (var integer i := 0; i < lengthof(erabs_admitted); i := i + 1) {
                            var ERabIdx idx := erabs_admitted[i];
                            erabs_left[i] := g_pars.erabs[idx];
      
    

    See my comment about `f_ERabList_compose()` in previous patch.

    Done

To view, visit change 41095. To unsubscribe, or for help writing mail filters, visit settings.