Attention is currently required from: arehbein, daniel, laforge, pespin.
View Change
1 comment:
File src/core/osmo_io.c:
Patch Set #3, Line 546: if (iofd->io_ops.read_cb)
i fail to see the problem though, can you explain?
ah ok, read_cb happens to be in the same place as recvfrom_cb, so only checking the one location worked out, but semantics dictate that we should check exactly the member that is matching the current iofd->mode.
Yet this fix seems orthogonal to removing the union?
To view, visit change 35079. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I138d57843edc29000530bb7896bcb239002ecbec
Gerrit-Change-Number: 35079
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: neels <nhofmeyr@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: arehbein <arehbein@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Dec 2023 02:08:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann@sysmocom.de>
Gerrit-MessageType: comment