Attention is currently required from: dexter.

Patch set 1:Code-Review -1

View Change

4 comments:

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #1, Line 315: struct gsm_bts_trx_ts *ts;

    can be moved to the scope where it's used (inner for loop)

  • Patch Set #1, Line 318: OSMO_ASSERT(bts);

    So you're removing these asserts in I8320cbc14361438d65642d15bc225e9960ce925b, but adding them here? Why?

  • Patch Set #1, Line 323: gsm_bts_trx_num

    This function is good for random access (give me Nth TRX), but really bad for sequential access because it does foreach lookup internally. Better use llist_for_each_entry() here:

      llist_for_each_entry(trx, &bts->trx_list, list) {
        // ...
      }

    You're already enforcing the PCU_IF_NUM_TRX limit below.

  • Patch Set #1, Line 326: if (trx->nr >= PCU_IF_NUM_TRX)

    This condition is always false because you're doing i < PCU_IF_NUM_TRX. CR-1.

To view, visit change 31144. To unsubscribe, or for help writing mail filters, visit settings.