Attention is currently required from: neels.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    It can still be used without having to initialize logging, as we do have a fallback mechanism: see #define LOGPSRCC and logp_stub().

    category DLGLOBAL is a bad fit, should we add DLBSSAP now?

    I don't think it's worth it. Be it good or bad, this is the only value we can use here ATM.

    a solution would be an error_cb(), concise error info is provided by the lib, the caller decides how to handle it.

    Too much complexity for... simply printing something that should not normally happen. IMHO.

    should we also add logging and better handling for all other error cases in this file?

    There are still plenty of assert()s in other enc_ functions waiting to be replaced ;)

To view, visit change 30581. To unsubscribe, or for help writing mail filters, visit settings.