Attention is currently required from: manawyrm, roox, laforge.

View Change

1 comment:

• File src/octoi/e1oip.c:

  • Patch Set #2, Line 255: rc = frame_rifo_in(&iline->e1t.rifo, frame_buf, fn32+i);

    so what kind of naming would you prefer? e1oip:e1t_out_of_ragge? out_of_window? I somehow like the […]

    Yeah, I think it's too much of a misnomer because in the stat in case of a desync we'll end up with 8000/s UNDERFLOW _and_ 8000/s OVERFLOW, that's just weird.

    I think DISCARDED maybe ? but I'm fine with "out of range".

    Or we can also have the rifo_in differentiate between too_old and too_new and have two counters, but that might be overkill.

To view, visit change 27841. To unsubscribe, or for help writing mail filters, visit settings.